Add sodium_crypto_secretbox_keygen function stub#4954
Merged
VincentLanglet merged 1 commit intophpstan:2.1.xfrom Feb 17, 2026
Merged
Add sodium_crypto_secretbox_keygen function stub#4954VincentLanglet merged 1 commit intophpstan:2.1.xfrom
VincentLanglet merged 1 commit intophpstan:2.1.xfrom
Conversation
staabm
approved these changes
Feb 16, 2026
Contributor
VincentLanglet
left a comment
VincentLanglet
left a comment
There was a problem hiding this comment.
Can it return '0' or is it non-falsy ?
Contributor
|
most of this 'encoding' functions just use non-empty-string atm. I think thats good enough. |
VincentLanglet
approved these changes
Feb 17, 2026
Contributor
|
Thank you @thePanz |
Contributor
Author
|
Thank you @staabm @VincentLanglet |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the docs, the function returns a non-empty string: https://www.php.net/manual/en/function.sodium-crypto-secretbox-keygen.php